Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in serviceMonitor add metricRelabelings & relabelings, fix labels #77

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

smartbit
Copy link

@smartbit smartbit commented Apr 5, 2022

Overview

fix & enhance serviceMonitor

What this PR does / why we need it

in serviceMonitor

  • fix indent for labels
  • add metricRelabelings: and in comments add sample to be able to recognize the metrics
  • add relabelings: for those who want them

Special notes for your reviewer

Updated Chart to v0.8.2, please push the appropriate version to https://charts.dexidp.io

Checklist

  • Change log updated in Chart.yaml (see the contributing guide for details)
  • Chart version bumped in Chart.yaml (see the contributing guide for details)
  • Documentation regenerated by running make docs

Signed-off-by: smartbit <smartbit@users.noreply.github.com>
Signed-off-by: smartbit <smartbit@users.noreply.github.com>
Signed-off-by: smartbit <smartbit@users.noreply.github.com>
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the change log and run make docs.
More details in the contribution guide.

@@ -1,7 +1,7 @@
apiVersion: v2
type: application
name: dex
version: 0.8.0
version: 0.8.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants