EES-4444 Swap pyderman for webdriver-manager #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces Pyderman, which currently doesn't support Chrome 115+ due to recent changes in how Chrome versions are published. See: - SergeyPirogov/webdriver_manager#580 - shadowmoose/pyderman#35
ntsim
requested review from
benoutram,
duncan-at-hiveit,
a user and
amyb-hiveit
ghost
approved these changes
Aug 21, 2023
| version=version, | ||
| ) | ||
| def get_webdriver(version: Optional[str] = None) -> None: | ||
| driver_path = ChromeDriverManager(driver_version=version).install() |
There was a problem hiding this comment.
Where is chromedriver getting saved?
Having it downloaded to the webdrivers directory previously was useful to allow you to manually download a different version and use that rather than what the script downloads, which has happened on occasion.
There was a problem hiding this comment.
As mentioned in the PR summary, all webdrivers get downloaded to your home directory in ~/.wdm. Each version downloaded gets its own directory, so you can just delete these as required.
However, I think WDM by default will just try and figure out what Chrome you're using and get the correct version based on that.
If you want to download a specific version, you'll need to use the --chromedriver flag when running the tests.
benoutram
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the downloading of Chromedriver to use webdriver-manager instead of pyderman. This was motivated by a recent change to how Chromedriver downloads are published, meaning that JSON endpoints should be called for correct versions: https://github.com/GoogleChromeLabs/chrome-for-testing#json-api-endpoints
Currently, webdriver-manager supports this, but pyderman does not. See:
Webdriver download directory
Note that a major difference with pyderman is that Webdrivers are now installed globally to your home directory in the
~/.wdmdirectory. The currentwebdriverdirectory in the project itself is now redundant and will not actually be used.