remove default includeEmptyNeurons=false from getNeuron and set test …

…to includeEmptyNeurons: false
dfinity · Oct 10, 2024 · 385a390 · 385a390
1 parent 9573096
commit 385a390
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/nns/src/governance.canister.spec.ts b/packages/nns/src/governance.canister.spec.ts
@@ -756,13 +756,13 @@ describe("GovernanceCanister", () => {
       const response = await governance.getNeuron({
         certified: true,
         neuronId,
-        includeEmptyNeurons: true,
+        includeEmptyNeurons: false,
       });
 
       expect(certifiedService.list_neurons).toBeCalledWith({
         neuron_ids: new BigUint64Array([neuronId]),
         include_neurons_readable_by_caller: false,
-        include_empty_neurons_readable_by_caller: [true],
+        include_empty_neurons_readable_by_caller: [false],
         include_public_neurons_in_full_neurons: [],
       });
 

diff --git a/packages/nns/src/governance.canister.ts b/packages/nns/src/governance.canister.ts
@@ -976,7 +976,7 @@ export class GovernanceCanister {
   public getNeuron = async ({
     certified = true,
     neuronId,
-    includeEmptyNeurons = false,
+    includeEmptyNeurons,
   }: {
     certified: boolean;
     neuronId: NeuronId;
@@ -989,9 +989,7 @@ export class GovernanceCanister {
     const [neuron]: NeuronInfo[] = await this.listNeurons({
       certified,
       neuronIds: [neuronId],
-      includeEmptyNeurons: includeEmptyNeurons
-        ? includeEmptyNeurons
-        : undefined,
+      includeEmptyNeurons,
     });
 
     return neuron;