Proposal based votable state #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js into proposal-based-votable-state
size-limit report 📦
|
…js into proposal-based-votable-state
dskloetd
reviewed
Oct 1, 2024
dskloetd
approved these changes
Oct 2, 2024
…js into proposal-based-votable-state
- Separate describe blocks - Remove duplications
1 task
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Oct 4, 2024
# Motivation There are multiple reports from users who can’t vote. We believe the root cause of this issue is the 100-ballot limit for neurons. If a user has voted on more than 100 proposals (a likely scenario over a 4-day period), they don’t receive ballots for proposals they’ve already voted on, which remain technically votable due to this limit. The suggested solution is to switch from using neuron ballots to proposal ballots when calculating the votable state. The utilities have already been already updated in `ic-js` - dfinity/ic-js#725 # Changes - `npm run upgrade:next` - Update the displayed votable neurons on proposal changes as well, since we use the proposal ballots to determine the neurons’ voting state. # Tests - Updated. - Manually 1. Created 100+ proposals. 2. Voted on them. 3. Ensured that some of them were still displayed as votable (due to the recentBallots limit). 4. Switched to the utilities that rely on the proposal ballots. 5. Verified that all the proposals previously displayed as votable (despite having already been voted on) were now displayed as voted. # Todos - [x] Add entry to changelog (if necessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are multiple reports from users who can’t vote. We believe the root cause of this issue is the 100-ballot limit for neurons. If a user has voted on more than 100 proposals (a likely scenario over a 4-day period), they don’t receive ballots for proposals they’ve already voted on, which remain technically votable due to this limit. The suggested solution is to switch from using neuron ballots to proposal ballots when calculating the votable state.
Changes
Tests
Todos
Not necessary.