Enable getNeuron to use the new service #728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
coskucinkilic
changed the title
coskucinkilic
changed the title
coskucinkilic
force-pushed
the
NNS1-3351-bulk-visibility-change
branch
2 times, most recently
from
64a11d5
to
bbebe15
Compare
…to includeEmptyNeurons: false
coskucinkilic
force-pushed
the
NNS1-3351-bulk-visibility-change
branch
from
e04394e
to
e3e581a
Compare
coskucinkilic
force-pushed
the
NNS1-3351-bulk-visibility-change
branch
from
01809ed
to
00641be
Compare
|
closed as it is replaced by this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I need to fetch visibility with getNeuron and it looks like old service doesn't provide that
Changes
includeEmptyNeurons props is added to getNeuron to use the new service
Tests
Add and updates tests to include when includeEmptyNeurons not provided it uses old service and includeEmptyNeurons provided it uses certified service
Todos
not necessary