Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment in old_list_neurons_service.certified.idl.js #730

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Update comment in old_list_neurons_service.certified.idl.js #730

merged 1 commit into from
Oct 11, 2024

Conversation

dskloetd
Copy link
Collaborator

Motivation

I updated the comment to be more accurate when updating the service file in #729 but then forgot to commit these changes.

Changes

Improve the comment's accuracy.

Tests

N/A

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review October 11, 2024 14:33
@dskloetd dskloetd requested review from a team as code owners October 11, 2024 14:33
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 7.99 KB (0%)
@dfinity/cketh 3.53 KB (0%)
@dfinity/cmc 1.3 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.23 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.87 KB (0%)
@dfinity/utils 4.5 KB (0%)
@dfinity/ic-management 3.01 KB (0%)

@dskloetd dskloetd enabled auto-merge (squash) October 11, 2024 14:40
@dskloetd dskloetd merged commit a11a884 into main Oct 11, 2024
11 checks passed
@dskloetd dskloetd deleted the kloet/old-service-comment branch October 11, 2024 14:50
@coskucinkilic coskucinkilic mentioned this pull request Oct 11, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coskucinkilic coskucinkilic coskucinkilic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @coskucinkilic