Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Extract createAgent parameters and export them #735

Merged
merged 10 commits into from
Oct 20, 2024
Merged

refactor: Extract createAgent parameters and export them #735

merged 10 commits into from
Oct 20, 2024

Conversation

AntonioVentilii-DFINITY
Copy link
Contributor

Motivation

This small refactoring provides a new interface to the user: the one used by the createAgent function.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 7.99 KB (0%)
@dfinity/cketh 3.53 KB (0%)
@dfinity/cmc 1.4 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.23 KB (0%)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.87 KB (0%)
@dfinity/utils 4.5 KB (0%)
@dfinity/ic-management 3.01 KB (0%)

peterpeterparker
peterpeterparker reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a comment.

packages/utils/src/utils/agent.utils.ts Outdated Show resolved Hide resolved
packages/utils/src/types/agent.utils.ts Outdated Show resolved Hide resolved
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY mentioned this pull request Oct 16, 2024
Merged
1 task
peterpeterparker
peterpeterparker approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit 2b76998 into main Oct 20, 2024
11 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the refactor/Extract-createAgent-parameters-and-export-them branch October 20, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioVentilii-DFINITY @peterpeterparker