Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid pocket-ic crate #101

Merged
merged 3 commits into from
Nov 18, 2024
Merged

avoid pocket-ic crate #101

merged 3 commits into from
Nov 18, 2024

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Nov 18, 2024

No description provided.

@mraszyk mraszyk mentioned this pull request Nov 18, 2024
Merged
chenyan-dfinity
chenyan-dfinity approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much cleaner to me!

@mraszyk mraszyk marked this pull request as ready for review November 18, 2024 18:19
@mraszyk mraszyk requested a review from a team as a code owner November 18, 2024 18:19
@mraszyk mraszyk merged commit 40d8433 into mraszyk/effective-canister-id Nov 18, 2024
1 check passed
@mraszyk mraszyk deleted the mraszyk/effective-canister-id-self-contained branch November 18, 2024 18:19
mraszyk added a commit that referenced this pull request Nov 18, 2024
@mraszyk
feat: make ic-repl work against PocketIC (#99)
61e3207 
* feat: make ic-repl work against PocketIC

* lazy

* dfx stop

* clean

* use fn get_default_effective_canister_id

* simplify deps

* bump dfx

* dfx version

* Revert "dfx version"

This reverts commit ab157dd.

* deps

* dfx

* avoid pocket-ic crate (#101)

* avoid pocket-ic crate

* .

* trim_end_matches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyan-dfinity chenyan-dfinity chenyan-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraszyk @chenyan-dfinity