Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc improvements #94

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Misc improvements #94

merged 13 commits into from
Jul 29, 2024

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Jul 10, 2024 •
edited
Loading

  • Change export command to export function
  • load 'a.sh?' silence the error if a.sh doesn't exist. load can take an expression instead of fixed text.
  • add __main function that can take arguments from CLI
  • exec function
  • replica_url function
  • add registry and cycles_ledger canister id
  • verbose mode -v. Without verbose mode, only output the result if the return type is text.

@chenyan-dfinity chenyan-dfinity changed the title export becomes a function; load 'file?' if file doesn't exist Misc improvements Jul 10, 2024
@chenyan-dfinity chenyan-dfinity mentioned this pull request Jul 10, 2024
Merged
@chenyan-dfinity chenyan-dfinity marked this pull request as ready for review July 29, 2024 20:41
@chenyan-dfinity chenyan-dfinity requested a review from a team as a code owner July 29, 2024 20:41
ericswanson-dfinity
ericswanson-dfinity approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor grammar fixes

src/exp.rs Outdated Show resolved Hide resolved
src/exp.rs Outdated Show resolved Hide resolved
@chenyan-dfinity @ericswanson-dfinity
Apply suggestions from code review
2adca4a 
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
@chenyan-dfinity chenyan-dfinity merged commit f0c546e into master Jul 29, 2024
3 checks passed
@chenyan-dfinity chenyan-dfinity deleted the misc branch July 29, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenyan-dfinity @ericswanson-dfinity