Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mobile footer title and text #2672

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Remove mobile footer title and text #2672

merged 3 commits into from
Oct 28, 2024
+1 −3

Conversation

LXIF
Copy link
Contributor

@LXIF LXIF commented Oct 25, 2024 •
edited by github-actions bot
Loading

Remove mobile footer and text as per https://dfinity.atlassian.net/browse/GIX-3120 (Note: this removes it also from the landing page. If we need to handle this case-by-case, please let me know)

🟡 Some screens were changed

@LXIF LXIF requested a review from a team as a code owner October 25, 2024 13:04
@LXIF LXIF requested a review from lmuntaner October 25, 2024 13:04
lmuntaner
lmuntaner approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To trigger a new review, you need to click on the "circle" icon next to my name in "Reviewers" list. And ideally also mention me in a comment so that I know that this can be reviewed again.

Thanks!

@LXIF LXIF added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 0d7d078 Oct 28, 2024
67 checks passed
@LXIF LXIF deleted the onboarding-improvements-2 branch October 28, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LXIF @lmuntaner