Add bindings for adjacent fix-width numerical conversions and flesh out docs #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentosugama
changed the title
luc-blaeser
reviewed
Aug 21, 2023
luc-blaeser
approved these changes
Aug 21, 2023
|
Thank you for the review @luc-blaeser |
|
Yes, nice work! It's merged already but there's small typo in all the toText explanations. "Textual representation" -> "Textual representations". Also the reference to the original underscore syntax is because Motoko accepts underscores as thousand separators in literal (not commas). Probably not worth fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose these: dfinity/motoko#4139
Converting to adjacent fix-width types for:
Int8Int16Int32Int64Nat8Nat16Nat32Nat64And fleshing out the documentation for these modules to be up to standard with the
NatandIntmodules.