Apply NaN canonicalization in base tests #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusso
approved these changes
Aug 18, 2023
mergify bot
pushed a commit
to dfinity/motoko
that referenced
this pull request
Aug 18, 2023
Enable NaN canonicalization for `wasm-run` Motoko test execution to get consistent results across different processor platforms. This is related to dfinity/motoko-base#586.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
nan(not a number) floating point representation with a negative sign onwasmtime. motoko#3647Enable NaN canonicalization for wasmtime test execution to get consistent results across different processor platforms.
Adjust the unit tests and documenation regarding the propagation of the NaN sign bit.
According to the Wasm specification and also the observed wasmtime behavior (with NaN canonicalization), the NaN sign is only properly set on
Float.abs,Float.neg, andFloat.copySign, not on the other floating point operations.