chore: update moc 0.13.4 #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusting the base library for latest Motoko RTS changes: * Also test enhanced orthogonal persistence with Wasm Memory 64. * Be prepared for the RTS dependency upgrade dfinity/motoko#4677 Changes: The original Musl float formatter has been replaced by the Rust implementation with some subtle format changes: - Numbers are displayed with the actually defined precision, no longer truncating trailing zeros and potentially revealing existing numeric errors. - The exponent is printed with an explicit sign and multiple digits. - NaN is formatted differently, now `NaN`, while the NaN sign bit is omitted. - The hexadecimal float formatter is no longer supported (`Float.format(#hex)`). This is probably acceptable as it is rarely used. Once we have dfinity/motoko#4677 merged in Motoko `master`, then we can remove the backwards compatibility of float formatting in these tests. Backwards compatibility is here needed to make `motoko-base` tests pass with the old Motoko compiler version. --------- Co-authored-by: Claudio Russo <claudio@dfinity.org>
luc-blaeser
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.