Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error logging when multiple DFX Registries are found #80

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

anchpop
Copy link
Contributor

@anchpop anchpop commented Sep 19, 2024

We can give a little more debug info in this case, and add a comment in case someone reads the code when trying to debug it. I didn't want to suggest in stdout the specific remedy of passing --clean to dfx because if someone is following the readme they should have already done that

@anchpop anchpop changed the title improve error logging Improve error logging when multiple DFX Registries are fine Sep 19, 2024
@anchpop anchpop changed the title Improve error logging when multiple DFX Registries are fine Improve error logging when multiple DFX Registries are found Sep 19, 2024
@anchpop anchpop marked this pull request as ready for review September 19, 2024 19:48
@anchpop anchpop requested review from mraszyk and a team as code owners September 19, 2024 19:48
constants.sh Show resolved Hide resolved
@anchpop anchpop merged commit b302925 into main Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants