🔖 1.7.5

dflook · Feb 6, 2023 · 23294b2 · 23294b2
1 parent 6834e21
commit 23294b2
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.7.5] - 2023-02-06
+
+### Fixed
+- Resolve cfn-lint check I3042 about hardcoded partition in arn. Thanks [CurryEleison](https://github.com/CurryEleison)!
+
 ## [1.7.4] - 2022-05-19
 
 ### Changed
@@ -77,6 +82,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - First release
 
+[1.7.5]: https://github.com/dflook/cloudformation-dns-certificate/compare/1.7.4...1.7.5
 [1.7.4]: https://github.com/dflook/cloudformation-dns-certificate/compare/1.7.3...1.7.4
 [1.7.3]: https://github.com/dflook/cloudformation-dns-certificate/compare/1.7.2...1.7.3
 [1.7.2]: https://github.com/dflook/cloudformation-dns-certificate/compare/1.7.1...1.7.2

diff --git a/cloudformation.py b/cloudformation.py
@@ -41,4 +41,4 @@ def create_template():
         f.write(template.to_yaml())
 
     with open('cloudformation.json', 'w') as f:
-        f.write(template.to_json())
+        f.write(template.to_json(indent=4))
diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 setup(
     name='troposphere-dns-certificate',
     description='Cloudformation DNS validated certificate resource for troposphere',
-    version='1.7.4',
+    version='1.7.5',
     author='Daniel Flook',
     author_email='daniel@flook.org',
     url='https://github.com/dflook/cloudformation-dns-certificate',

diff --git a/test/test.sh b/test/test.sh
@@ -2,12 +2,12 @@
 
 set -e
 
-HOSTED_ZONE_NAME=flook.org
-HOSTED_ZONE_ID=Z2KZ5YTUFZNC7G
-HOSTED_ZONE_ARN=arn:aws:iam::352732628874:role/Route53Role
-HOSTED_ZONE2_NAME=flook.dev
-HOSTED_ZONE2_ID=Z1ZTN5O45UNNUW
-HOSTED_ZONE2_ARN=arn:aws:iam::352732628874:role/Route53Role
+HOSTED_ZONE_NAME=example.com
+HOSTED_ZONE_ID=ABCDEFG123456
+HOSTED_ZONE_ARN=arn:aws:iam::11111111111:role/Route53Role
+HOSTED_ZONE2_NAME=example.org
+HOSTED_ZONE2_ID=ZXCVBNM09876
+HOSTED_ZONE2_ARN=arn:aws:iam::22222222222:role/Route53Role
 
 ./create_test_template.py $HOSTED_ZONE_NAME $HOSTED_ZONE_ID $HOSTED_ZONE_ARN $HOSTED_ZONE2_NAME $HOSTED_ZONE2_ID $HOSTED_ZONE2_ARN> test.yaml
 
@@ -24,6 +24,9 @@ do
 
     echo "Success in $region"
     aws cloudformation delete-stack --stack-name dns-cert-test
+
+    echo "sleeping"
+    sleep 30
 done
 
 echo "Success in all regions"