Merge pull request #18 from CurryEleison/cfn-lint-partitions

Fix linting warnings relating to AWS partitions
dflook · Feb 6, 2023 · 6834e21 · 6834e21
2 parents 070ec56 + a54d144
commit 6834e21
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -324,7 +324,7 @@ CustomAcmCertificateLambdaExecutionRole:
                 - acm:RemoveTagsFromCertificate
               Effect: Allow
               Resource:
-                - !Sub 'arn:aws:acm:*:${AWS::AccountId}:certificate/*'
+                - !Sub 'arn:${AWS::Partition}:acm:*:${AWS::AccountId}:certificate/*'
             - Action:
                 - acm:RequestCertificate
                 - acm:ListTagsForCertificate

diff --git a/cloudformation.json b/cloudformation.json
@@ -66,7 +66,7 @@
                                     "Effect": "Allow",
                                     "Resource": [
                                         {
-                                            "Fn::Sub": "arn:aws:acm:*:${AWS::AccountId}:certificate/*"
+                                            "Fn::Sub": "arn:${AWS::Partition}:acm:*:${AWS::AccountId}:certificate/*"
                                         }
                                     ]
                                 },

diff --git a/cloudformation.yaml b/cloudformation.yaml
@@ -61,7 +61,7 @@ Resources:
                   - acm:RemoveTagsFromCertificate
                 Effect: Allow
                 Resource:
-                  - !Sub 'arn:aws:acm:*:${AWS::AccountId}:certificate/*'
+                  - !Sub 'arn:${AWS::Partition}:acm:*:${AWS::AccountId}:certificate/*'
               - Action:
                   - acm:RequestCertificate
                   - acm:ListTagsForCertificate

diff --git a/src/troposphere_dns_certificate/certificatemanager.py b/src/troposphere_dns_certificate/certificatemanager.py
@@ -55,7 +55,7 @@ def add_helpers(template):
                                         Action('acm', 'RemoveTagsFromCertificate'),
 
                                     ],
-                                    Resource=[Sub('arn:aws:acm:*:${AWS::AccountId}:certificate/*')],
+                                    Resource=[Sub('arn:${AWS::Partition}:acm:*:${AWS::AccountId}:certificate/*')],
                                 ),
                                 Statement(
                                     Effect=Allow,