Skip to content

Commit

Permalink
📚 Add note that top-level Route53RoleArn still works
Browse files Browse the repository at this point in the history
  • Loading branch information
dflook committed Jan 26, 2019
1 parent 151036b commit ca0b1fd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
pip3 install --upgrade setuptools wheel twine pip
python3 setup.py sdist bdist_wheel
twine upload --sign dist/*
twine upload --sign --skip-existing dist/*
- store_artifacts:
path: dist/
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ If you are using troposphere you can install this resource as an extension using

$ pip install troposphere_dns_certificate

You can then import the Certificate resource from troposphere_dns_certificate.certificatemanager instead of
troposphere.certificatemanager.
You can then import the Certificate resource from troposphere_dns_certificate.certificatemanager instead of troposphere.certificatemanager.

cloudformation.py is an example of using troposphere to create a template with a Certificate resource.

Expand Down Expand Up @@ -156,6 +155,9 @@ In some cases the account owning the hosted zone might be a different one than t
To support this you can specify the domain validation option property `Route53RoleArn` with a role-ARN that should be
assumed before creating the records required for certificate validation.

If a top-level Route53RoleArn property is specified it will be assumed when validating domains that don't contain a
Route53RoleArn domain validation option property.

```yaml
ExampleCertificate:
Properties:
Expand Down

0 comments on commit ca0b1fd

Please sign in to comment.