Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actinides #31

Merged
merged 24 commits into from
Oct 20, 2023
Merged

Actinides #31

merged 24 commits into from
Oct 20, 2023

Conversation

FreeSoulIG
Copy link
Contributor

This is an implementation of DFTD3 for all actinide elements + Fr, Ra.
All the necessary parameters (C6 coefficients, Rcutoff, CN for reference systems) have been updated for previously contained actinides. Also, the tests have been adjusted accordingly to match the new dimensions of the precomputed data (C6 coefficients and Rcutoff, the new test molecule AmF3 was added).

FreeSoulIG and others added 23 commits September 5, 2023 14:19
…des + Fr, Ra. The strategy employed to calculate the new values is to use the scaled by 0.7 sum of respective covalent radii for every element pair
… new version contains all dynamic polarizabilities for all reference structures of all actinides elements + Fr, Ra.
…atch the dimensions of new CN and C6 precomputed tensors.
…y and CN,weights,C6,disp2,disp3 values in samples.py
tests/test_disp.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #31 (086cd47) into main (f6d7464) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          18       18           
  Lines         362      362           
  Branches       42       42           
=======================================
  Hits          357      357           
  Misses          4        4           
  Partials        1        1           
Files Coverage Δ
src/tad_dftd3/data.py 100.00% <100.00%> (ø)
src/tad_dftd3/disp.py 100.00% <ø> (ø)
src/tad_dftd3/model.py 100.00% <ø> (ø)
src/tad_dftd3/reference.py 91.22% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marvinfriede marvinfriede merged commit b943853 into dftd3:main Oct 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants