Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and GPU tests #22

Merged
merged 12 commits into from
Dec 10, 2023
Merged

Refactor and GPU tests #22

merged 12 commits into from
Dec 10, 2023

Conversation

marvinfriede
Copy link
Member

@marvinfriede marvinfriede commented Nov 26, 2023

  • add --cuda flag for running all tests in GPU
  • improve triples mask
  • restructure to be consistent with tad-dftd3

@marvinfriede marvinfriede linked an issue Nov 26, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (82a9ee1) 98.84% compared to head (da33041) 97.56%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/tad_dftd4/utils/grad.py 40.00% 9 Missing ⚠️
src/tad_dftd4/charges.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   98.84%   97.56%   -1.28%     
==========================================
  Files          23       26       +3     
  Lines         519      576      +57     
  Branches       49       55       +6     
==========================================
+ Hits          513      562      +49     
- Misses          3       12       +9     
+ Partials        3        2       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marvinfriede marvinfriede mentioned this pull request Dec 8, 2023
@marvinfriede marvinfriede merged commit 5199029 into main Dec 10, 2023
14 of 16 checks passed
@marvinfriede marvinfriede deleted the refactor branch December 10, 2023 17:37
@marvinfriede marvinfriede added the refactor Code refactoring label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix real_triples
1 participant