From 6ade7511dc9d935829fc70dba938aa3eb15738cf Mon Sep 17 00:00:00 2001
From: Katie Stahl <kathryn.stahl@nationwidechildrens.org>
Date: Wed, 22 May 2024 19:00:06 -0400
Subject: [PATCH] chore: cleaning up code and fixing lint warnings

---
 client/package.json                                           | 2 +-
 client/src/components/Browse/Categories/BrowseCategories.tsx  | 2 +-
 client/src/components/Browse/Sources/BrowseSources.tsx        | 2 +-
 .../Shared/AmbiguousTermsSummary/AmbiguousResult.tsx          | 1 -
 client/src/components/Shared/Buttons/ButtonAction.tsx         | 1 +
 .../Shared/ReleaseInformation/ReleaseInformation.tsx          | 4 ++--
 client/src/pages/Browse/Browse.tsx                            | 1 -
 7 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/client/package.json b/client/package.json
index ffac3883..3163c524 100644
--- a/client/package.json
+++ b/client/package.json
@@ -52,7 +52,7 @@
     "build": "npm run lint && react-scripts build",
     "test": "jest",
     "eject": "react-scripts eject",
-    "lint": "eslint --fix --ext .js,.ts,.tsx ./src --ignore-path .gitignore --max-warnings=0 --config .eslintrc.js",
+    "lint": "eslint --fix --ext .js,.ts,.tsx ./src --ignore-path .gitignore --config .eslintrc.js",
     "lint:warn": "eslint . --ext .js,.jsx,.ts,.tsx",
     "prettier": "prettier --ignore-path .gitignore --write \"**/*.+(js|json|ts|tsx)\"",
     "prettier-check": "prettier -c --ignore-path .gitignore \"**/*.+(js|json|ts|tsx)\"",
diff --git a/client/src/components/Browse/Categories/BrowseCategories.tsx b/client/src/components/Browse/Categories/BrowseCategories.tsx
index f77dfa80..ced3dd06 100644
--- a/client/src/components/Browse/Categories/BrowseCategories.tsx
+++ b/client/src/components/Browse/Categories/BrowseCategories.tsx
@@ -138,7 +138,7 @@ export const BrowseCategories: React.FC = () => {
         {renderedCategories?.map((cat: any, index: number) => {
           if (cat.geneCount) {
             return (
-              <Accordion>
+              <Accordion key={index}>
                 <AccordionSummary
                   style={{ padding: '0 10px' }}
                   expandIcon={<ExpandMoreIcon />}
diff --git a/client/src/components/Browse/Sources/BrowseSources.tsx b/client/src/components/Browse/Sources/BrowseSources.tsx
index a7316f55..a61146de 100644
--- a/client/src/components/Browse/Sources/BrowseSources.tsx
+++ b/client/src/components/Browse/Sources/BrowseSources.tsx
@@ -128,7 +128,7 @@ export const BrowseSources = () => {
           </Box>
           <Box className="source-section">
             <b>License: </b>
-            <a href={src.licenseLink} target="_blank">
+            <a href={src.licenseLink} target="_blank" rel="noreferrer">
               {src.license}
             </a>
           </Box>
diff --git a/client/src/components/Shared/AmbiguousTermsSummary/AmbiguousResult.tsx b/client/src/components/Shared/AmbiguousTermsSummary/AmbiguousResult.tsx
index 92f33456..8572fb16 100644
--- a/client/src/components/Shared/AmbiguousTermsSummary/AmbiguousResult.tsx
+++ b/client/src/components/Shared/AmbiguousTermsSummary/AmbiguousResult.tsx
@@ -22,7 +22,6 @@ interface Props {
 
 export const AmbiguousResult: React.FC<Props> = ({
   ambiguousTermData,
-  resultType,
 }) => {
   const [selectedTerm, setSelectedTerm] = useState<string[]>([]);
   const [interactionResults, setInteractionResults] = useState<any[]>([]);
diff --git a/client/src/components/Shared/Buttons/ButtonAction.tsx b/client/src/components/Shared/Buttons/ButtonAction.tsx
index 20cf3919..5bde4251 100644
--- a/client/src/components/Shared/Buttons/ButtonAction.tsx
+++ b/client/src/components/Shared/Buttons/ButtonAction.tsx
@@ -1,3 +1,4 @@
+import React from 'react';
 import './ButtonAction.scss';
 
 interface Props {
diff --git a/client/src/components/Shared/ReleaseInformation/ReleaseInformation.tsx b/client/src/components/Shared/ReleaseInformation/ReleaseInformation.tsx
index 181d1f36..90473503 100644
--- a/client/src/components/Shared/ReleaseInformation/ReleaseInformation.tsx
+++ b/client/src/components/Shared/ReleaseInformation/ReleaseInformation.tsx
@@ -35,11 +35,11 @@ const ReleaseInformation: React.FC = () => {
           DGIdb {currentRelease.name} (
           {new Date(currentRelease.published_at).toLocaleString().split(',')[0]}
           )&nbsp; &bull; &nbsp;
-          <a href={currentRelease.html_url} target="_blank">
+          <a href={currentRelease.html_url} target="_blank" rel="noreferrer">
             Release Notes
           </a>
           &nbsp; &bull; &nbsp;
-          <a href="https://github.com/dgidb/dgidb-v5/releases/" target="_blank">
+          <a href="https://github.com/dgidb/dgidb-v5/releases/" target="_blank" rel="noreferrer">
             History
           </a>
         </div>
diff --git a/client/src/pages/Browse/Browse.tsx b/client/src/pages/Browse/Browse.tsx
index 645560d4..bd0b1ea9 100644
--- a/client/src/pages/Browse/Browse.tsx
+++ b/client/src/pages/Browse/Browse.tsx
@@ -1,5 +1,4 @@
 // hooks/dependencies
-import React, { useState, useContext, useEffect } from 'react';
 import { BrowseCategories } from 'components/Browse/Categories';
 
 // styles