feat: store score components in DB #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcannon068nw
approved these changes
Aug 28, 2024
Comment on lines
+54
to
77
| def calculate_interaction_score(drug_partners_per_gene = nil, gene_partners_per_drug = nil, update = false) | ||
| drug_partners_per_gene = Interaction.group(:gene_id).count if drug_partners_per_gene.nil? | ||
| avg_drug_partners_per_gene = drug_partners_per_gene.values.sum / drug_partners_per_gene.values.size.to_f | ||
| drug_partners_for_this_gene = drug_partners_per_gene[gene_id] | ||
|
|
||
| (self.publications.count + self.sources.count) * average_known_gene_partners_per_drug/known_gene_partners_for_interaction_drug * average_known_drug_partners_per_gene/known_drug_partners_for_interaction_gene | ||
| gene_partners_per_drug = Interaction.group(:drug_id).count if gene_partners_per_drug.nil? | ||
| avg_gene_partners_per_drug = gene_partners_per_drug.values.sum / gene_partners_per_drug.values.size.to_f | ||
| gene_partners_for_this_drug = gene_partners_per_drug[drug_id] | ||
|
|
||
| drug_specificity = avg_gene_partners_per_drug / gene_partners_for_this_drug | ||
| gene_specificity = avg_drug_partners_per_gene / drug_partners_for_this_gene | ||
| evidence_score = publications.count + sources.count | ||
| interaction_score = evidence_score * drug_specificity * gene_specificity | ||
|
|
||
| if update | ||
| self.score = interaction_score | ||
| self.drug_specificity = drug_specificity | ||
| self.gene_specificity = gene_specificity | ||
| self.evidence_score = evidence_score | ||
| save! | ||
| end | ||
|
|
||
| interaction_score | ||
| end |
There was a problem hiding this comment.
this looks right, at least as far as https://dgidb.org/about#interaction-scores is concerned. I would like to get @acoffman just to confirm that the ruby isn't doing anything unexpected here
There was a problem hiding this comment.
This looks correct to me on first glance. Only "gotcha" I could think of is defaulting to integer division between two ints but it looks like that's covered by the .to_f calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support #515