Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store score components in DB #518

Merged
merged 4 commits into from
Aug 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions server/app/graphql/types/interaction_type.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ class InteractionType < Types::BaseObject
field :publications, [Types::PublicationType], null: false
field :sources, [Types::SourceType], null: false
field :interaction_score, Float, null: false
field :drug_specificity, Float, null: false
field :gene_specificity, Float, null: false
field :evidence_score, Integer, null: false

def interaction_claims
Loaders::AssociationLoader.for(Interaction, :interaction_claims).load(object)
Expand Down
30 changes: 22 additions & 8 deletions server/app/models/interaction.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,29 @@ def interaction_score(known_drug_partners_per_gene = nil, known_gene_partners_pe
end
end

def calculate_interaction_score(known_drug_partners_per_gene = nil, known_gene_partners_per_drug = nil)
known_drug_partners_per_gene = Interaction.group(:gene_id).count if known_drug_partners_per_gene.nil?
average_known_drug_partners_per_gene = known_drug_partners_per_gene.values.sum / known_drug_partners_per_gene.values.size.to_f
known_gene_partners_per_drug = Interaction.group(:drug_id).count if known_gene_partners_per_drug.nil?
average_known_gene_partners_per_drug = known_gene_partners_per_drug.values.sum / known_gene_partners_per_drug.values.size.to_f
known_drug_partners_for_interaction_gene = known_drug_partners_per_gene[self.gene_id]
known_gene_partners_for_interaction_drug = known_gene_partners_per_drug[self.drug_id]
def calculate_interaction_score(drug_partners_per_gene = nil, gene_partners_per_drug = nil, update = false)
drug_partners_per_gene = Interaction.group(:gene_id).count if drug_partners_per_gene.nil?
avg_drug_partners_per_gene = drug_partners_per_gene.values.sum / drug_partners_per_gene.values.size.to_f
drug_partners_for_this_gene = drug_partners_per_gene[gene_id]

(self.publications.count + self.sources.count) * average_known_gene_partners_per_drug/known_gene_partners_for_interaction_drug * average_known_drug_partners_per_gene/known_drug_partners_for_interaction_gene
gene_partners_per_drug = Interaction.group(:drug_id).count if gene_partners_per_drug.nil?
avg_gene_partners_per_drug = gene_partners_per_drug.values.sum / gene_partners_per_drug.values.size.to_f
gene_partners_for_this_drug = gene_partners_per_drug[drug_id]

drug_specificity = avg_gene_partners_per_drug / gene_partners_for_this_drug
gene_specificity = avg_drug_partners_per_gene / drug_partners_for_this_gene
evidence_score = publications.count + sources.count
interaction_score = evidence_score * drug_specificity * gene_specificity

if update
self.score = interaction_score
self.drug_specificity = drug_specificity
self.gene_specificity = gene_specificity
self.evidence_score = evidence_score
save!
end

interaction_score
end
Comment on lines +54 to 77
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks right, at least as far as https://dgidb.org/about#interaction-scores is concerned. I would like to get @acoffman just to confirm that the ruby isn't doing anything unexpected here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me on first glance. Only "gotcha" I could think of is defaulting to integer division between two ints but it looks like that's covered by the .to_f calls.


end
7 changes: 7 additions & 0 deletions server/db/migrate/20240826185158_add_score_components.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class AddScoreComponents < ActiveRecord::Migration[6.1]
def change
add_column :interactions, :drug_specificity, :float
add_column :interactions, :gene_specificity, :float
add_column :interactions, :evidence_score, :integer
end
end
8 changes: 6 additions & 2 deletions server/db/structure.sql
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,10 @@ CREATE TABLE public.interactions (
id text NOT NULL,
drug_id text NOT NULL,
gene_id text NOT NULL,
score numeric
score numeric,
drug_specificity double precision,
gene_specificity double precision,
evidence_score integer
);


Expand Down Expand Up @@ -1878,6 +1881,7 @@ INSERT INTO "schema_migrations" (version) VALUES
('20220523183117'),
('20230104221712'),
('20230110183235'),
('20230214150515');
('20230214150515'),
('20240826185158');


7 changes: 3 additions & 4 deletions server/lib/genome/groupers/interaction_grouper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,11 @@ def self.add_member(interaction_claim)
def self.cache_interaction_scores
count = Interaction.count

known_drug_partners_per_gene = Interaction.group(:gene_id).count
known_gene_partners_per_drug = Interaction.group(:drug_id).count
drug_partners_per_gene = Interaction.group(:gene_id).count
gene_partners_per_drug = Interaction.group(:drug_id).count
pbar = ProgressBar.create(title: 'Calculating interaction scores', total: count, format: "%t: %p%% %a |%B|")
Interaction.find_each do |interaction|
interaction.score = interaction.calculate_interaction_score(known_drug_partners_per_gene, known_gene_partners_per_drug)
interaction.save!
interaction.calculate_interaction_score(drug_partners_per_gene, gene_partners_per_drug, true)
pbar.progress += 1
end
end
Expand Down
Loading