Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing holtWinters* functions #66

Closed
JaderDias opened this issue Jul 21, 2015 · 5 comments
Closed

Missing holtWinters* functions #66

JaderDias opened this issue Jul 21, 2015 · 5 comments

Comments

@JaderDias
Copy link
Contributor

There are people that would like to use with carbonapi the holtWinters functions present in the python version
@dgryski
Copy link
Member

dgryski commented Jul 21, 2015

Use https://github.com/datastream/holtwinters as a base instead of doing the math ourselves, if possible.

@dgryski
Copy link
Member

dgryski commented Sep 10, 2015

This has stalled slightly because it's not just a case of dropping-in a library. HoltWinters needs several weeks of earlier data in order to correctly compute the seasonality for its predictions, which means we need to collect bootstrap data similar to how timeShift() works.

@iftekhar25 iftekhar25 mentioned this issue Oct 6, 2015
Merged
@dgryski
Copy link
Member

dgryski commented Sep 3, 2016

I'm replacing the Holt-Winters code and hopefully will fix this at the same time.

@dgryski
Copy link
Member

dgryski commented Sep 5, 2016

The patch in d4efd70 can be easily extended to add in the two other HW functions we're missing.

As far as I can tell, nobody is using them at the moment, so I won't implement that right now.

@arodland arodland mentioned this issue Dec 16, 2016
Merged
@dgryski
Copy link
Member

dgryski commented Dec 20, 2016

This is sufficiently done.

@dgryski dgryski closed this as completed Dec 20, 2016
gunnihinn pushed a commit that referenced this issue Jul 5, 2018
@Civil
Modify test to cause panic for close of closed channel
dadfcb9 
Related to #66
gunnihinn pushed a commit that referenced this issue Jul 5, 2018
@Civil
Make zipper's cache safer
4896551 
* Fix race condition for close and read of QueryFinished channel (by introducing mutex around it)
* Cache returns "nil, true" in case of timeout

Should fix #66
msaf1980 pushed a commit to msaf1980/carbonapi that referenced this issue Sep 12, 2022
@leizor
Merge pull request go-graphite#66 from grafana/leizor/transmog/issue-…
67f0e64 
…1419

Add missing tags based on MetricData.Name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JaderDias @dgryski