-
Notifications
You must be signed in to change notification settings - Fork 37
/
oddcompare.yml
59 lines (59 loc) · 1.44 KB
/
oddcompare.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
# flag these odd comparisons as they all have simpler
# equivalents with just $X and $Y and no zero term
rules:
- id: odd-comparison-subtract-eq-zero
patterns:
- pattern: $X - $Y == 0
fix: $X == $Y
message: "Odd comparison"
languages: [go]
severity: ERROR
- id: odd-comparison-subtract-neq-zero
patterns:
- pattern: $X - $Y != 0
fix: $X != $Y
message: "Odd comparison"
languages: [go]
severity: ERROR
- id: odd-comparison-subtract-lt-zero
patterns:
- pattern: $X - $Y < 0
fix: $Y > $X
message: "Odd comparison"
languages: [go]
severity: ERROR
- id: odd-comparison-subtract-lte-zero
patterns:
- pattern: $X - $Y <= 0
fix: $Y >= $X
message: "Odd comparison"
languages: [go]
severity: ERROR
- id: odd-comparison-subtract-gt-zero
patterns:
- pattern: $X - $Y > 0
fix: $X > $Y
message: "Odd comparison"
languages: [go]
severity: ERROR
- id: odd-comparison-subtract-gte-zero
patterns:
- pattern: $X - $Y >= 0
fix: $X >= $Y
message: "Odd comparison"
languages: [go]
severity: ERROR
- id: odd-comparison-xor-eq-zero
patterns:
- pattern: $X ^ $Y == 0
fix: $X == $Y
message: "Odd comparison"
languages: [go]
severity: ERROR
- id: odd-comparison-xor-neq-zero
patterns:
- pattern: $X ^ $Y != 0
fix: $X != $Y
message: "Odd comparison"
languages: [go]
severity: ERROR