Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zomato-clone #165

Closed
wants to merge 4 commits into from
Closed

zomato-clone #165

wants to merge 4 commits into from

Conversation

kratik1237
Copy link

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
write issue no. here
#120

Email id used to regsiter for VSoc'24

kratikkhatri7287@gmail.com

Description

[Please include a brief description of the changes or features added]
created a zomato clone for a 50_days_50_web_project repository using HTML,CSS and JS .

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Security enhancement
  • Other (specify): added a new project

check in issue by entering [X] in boxes

Screenshots / Videos (if applicable)

Screenshot (25)
Screenshot (26)
Screenshot (27)
Screenshot (28)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

  • I have performed a self-review of my code.
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have followed the code style guidelines of this project.
  • I have checked for any existing open issues that my pull request may address.
  • I have ensured that my changes do not break any existing functionality.
  • Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
  • I have read the resources for guidance listed below.
  • I have followed security best practices in my code changes.

check in issue by entering [X] in boxes

Additional Context

[Include any additional information or context that might be helpful for reviewers.]

Contribution Guidelines

Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:

Issue Creation

  1. Limit on Issues:
    • Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

  1. Basic Contributions:

    • This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
    • For these tasks, issues will be assigned the Easy label.
  2. Acknowledging Hard Work:

    • If a contributor puts in significant effort on a task, the issue will be upgraded to Medium. This is our way of recognizing and appreciating extra effort.
  3. Feature Additions and Component Work:

    • Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
    • The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

  • Easy:
    • Tasks are straightforward, such as fixing minor bugs, writing tests, or making simple documentation updates.
  • Medium:
    • Tasks require more effort, such as addressing complex bugs, improving existing features, or making substantial documentation improvements.
  • Hard:
    • Tasks are highly complex and involve significant new feature development, major refactoring, or extensive contributions to the project’s core components.

We look forward to your contributions and appreciate your effort in helping us improve the project!

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
50-days-50-web-project ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 4:42am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi dhairyagothi self-requested a review June 24, 2024 17:51
Copy link
Owner

@dhairyagothi dhairyagothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
update index.html

@dhairyagothi
Copy link
Owner

@kratik1237 bro pull main branch first then add it

Uploading image.png…

@dhairyagothi
Copy link
Owner

@kratik1237 bro pull main branch first then add it

image

@dhairyagothi
Copy link
Owner

image

conflicts are there

@kratik1237
Copy link
Author

how to pull the request
i don't no
@dhairyagothi

@dhairyagothi
Copy link
Owner

how to pull the request i don't no @dhairyagothi

go to fork repository sync fork then go to github desktop and pull origin and make changes accordingly in index.html

@dhairyagothi
Copy link
Owner

@kratik1237 Sync fork and make a new PR

@kratik1237
Copy link
Author

@dhairyagothi new pr bhi generate nhi ho rhaa ab

@kratik1237
Copy link
Author

@dhairyagothi bro pr generat bhi nhi hon rhe ab to.

@dhairyagothi
Copy link
Owner

Fork delete kar ke wapis banao @kratik1237

@kratik1237
Copy link
Author

kratik1237 commented Jul 1, 2024

Uploading IMG_20240701_170819.jpg …

@dhairyagothi har bar ye Bata rhaa

@dhairyagothi
Copy link
Owner

image show nhi ho rahi

@kratik1237
Copy link
Author

@dhairyagothi har bar ye Bata rhaa

IMG_20240701_170819.jpg

@dhairyagothi
Copy link
Owner

reclone repo

@kratik1237
Copy link
Author

@dhairyagothi ?

@kratik1237
Copy link
Author

Kese kru?@dhairyagothi

@kratik1237
Copy link
Author

Please guide @dhairyagothi

@kratik1237
Copy link
Author

Kr diya reclone but fir bhi nhi Ho rha@dhairyagothi

@kratik1237
Copy link
Author

kratik1237 commented Jul 1, 2024

Fir ye bta rha hai !@dhairyagothi IMG_20240701_170819.jpg

1 similar comment
@kratik1237
Copy link
Author

Fir ye bta rha hai !@dhairyagothi IMG_20240701_170819.jpg

@kratik1237
Copy link
Author

Please check the pr @dhairyagothi #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants