Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable macos 86/arm release #2590

Merged
merged 12 commits into from
May 31, 2024
Merged

enable macos 86/arm release #2590

merged 12 commits into from
May 31, 2024

Conversation

winitzki
Copy link
Collaborator

@winitzki winitzki commented May 31, 2024

The build should create macos-x86_64 and macos-arm64 executables and publish them.

@winitzki
Copy link
Collaborator Author

winitzki commented May 31, 2024

@mmhat I could not follow one of your comments in the previous PR:

Also use runner.arch in the conditional executions here:

if [ '${{matrix.os.runner}}' == 'windows-latest' ] && [ "${package}" == 'dhall-nix' ]; then 

...

if [ '${{matrix.os.runner}}' == 'windows-latest' ] && [ "${package}" == 'dhall-nix' ]; then 

I'm not sure how to modify those conditionals to use runner.arch. Right now we have only one runner under windows.

@winitzki winitzki requested a review from mmhat May 31, 2024 13:10
@winitzki
Copy link
Collaborator Author

winitzki commented May 31, 2024

@mmhat I followed your comments in the previous PR but it seems I'm doing something wrong. There is an error with main.yml saying that runner is undefined.

https://github.com/dhall-lang/dhall-haskell/actions/runs/9318616557

@mmhat
Copy link
Collaborator

mmhat commented May 31, 2024

@winitzki Oh I guess I didn't read the docs thoroughly... The runner context is of course only available when we have a runner 🙂 At line 35 of the failed job you linked we do not have a runner yet, that part is interpreted before a runner picks up a job of the workflow.

TLDR; We can only use the runner context inside the steps; I.e. whenever we could write shell code then the runner context is available there. That's at least how I understand the docs...

EDIT:
See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for the availability of the different contexts.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.mergify.yml Outdated Show resolved Hide resolved
winitzki and others added 9 commits May 31, 2024 19:23
Co-authored-by: Mann mit Hut <mmhat@users.noreply.github.com>
Co-authored-by: Mann mit Hut <mmhat@users.noreply.github.com>
Co-authored-by: Mann mit Hut <mmhat@users.noreply.github.com>
Co-authored-by: Mann mit Hut <mmhat@users.noreply.github.com>
Co-authored-by: Mann mit Hut <mmhat@users.noreply.github.com>
Co-authored-by: Mann mit Hut <mmhat@users.noreply.github.com>
@mmhat mmhat merged commit 3b47381 into main May 31, 2024
7 checks passed
@mmhat mmhat deleted the feature/publish-macos-builds branch May 31, 2024 19:43
@mmhat
Copy link
Collaborator

mmhat commented May 31, 2024

@winitzki Nice work!

@winitzki
Copy link
Collaborator Author

@winitzki Nice work!

Thank you for your timely help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants