Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade from CRA to Vite #512

Merged
merged 23 commits into from
Jul 25, 2024
Merged

refactor: upgrade from CRA to Vite #512

merged 23 commits into from
Jul 25, 2024

Conversation

Mohammer5
Copy link
Collaborator

@Mohammer5 Mohammer5 commented Jul 16, 2024

I've added our dhis2 linter & prettier configs (by just copying them over). I haven't applied them so I can rebase / merge any changes in master while this PR is still in review.

If you want to check out the amount of changes, just run yarn eslint (for eslint) or yarn prettier (for prettier; running yarn lint will fail (due to eslint issues), so it won't display the prettier issues).

Known issues

  • Jest tests of .tsx files doesn't work right now.
    There aren't any component tests yet, so it's something we can address after merging this PR. But we should address is!
  • This repo now uses prettier and eslint directly, which means we can't have the convenience of d2-style anymore.
    But this is in line with what we want to move towards anyway, see this slack message.
  • We can't use "type": "module" in the package.json (see here)

@Mohammer5 Mohammer5 marked this pull request as ready for review July 16, 2024 14:41
@Mohammer5 Mohammer5 marked this pull request as draft July 16, 2024 14:41
Copy link
Collaborator

@HendrikThePendric HendrikThePendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but only minor points, so LGTM 🚀

.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.cjs Outdated Show resolved Hide resolved
@Mohammer5 Mohammer5 marked this pull request as ready for review July 22, 2024 08:10
@Mohammer5 Mohammer5 force-pushed the DEVOPS-428 branch 4 times, most recently from 862f851 to d0c8616 Compare July 22, 2024 08:40
Copy link
Collaborator

@Chisomchima Chisomchima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.eslintrc.cjs Outdated Show resolved Hide resolved
.prettierrc.cjs Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.prettierignore Outdated Show resolved Hide resolved
.prettierrc.cjs Outdated Show resolved Hide resolved
src/views/databases/upload-database-modal.tsx Outdated Show resolved Hide resolved
@tonsV2 tonsV2 self-requested a review July 25, 2024 10:55
@Mohammer5 Mohammer5 merged commit f87d306 into master Jul 25, 2024
4 checks passed
@Mohammer5 Mohammer5 deleted the DEVOPS-428 branch July 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants