fix: Update code

dhis2 · Nov 24, 2024 · 7db77c5 · 7db77c5
1 parent ec6c906
commit 7db77c5
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/...analytics/src/main/java/org/hisp/dhis/analytics/table/JdbcEventAnalyticsTableManager.java b/...analytics/src/main/java/org/hisp/dhis/analytics/table/JdbcEventAnalyticsTableManager.java
@@ -659,7 +659,7 @@ private List<AnalyticsTableColumn> getColumnsFromOrgUnitTrackedEntityAttribute(
   }
 
   /**
-   * Creates a select statement for data element insertion.
+   * Creates a select statement for the given select expression.
    *
    * @param dataElement the data element to create the select statement for.
    * @param selectExpression the select expression.
@@ -687,8 +687,16 @@ private String getSelectForInsert(
     return replaceQualify(sqlTemplate, variables);
   }
 
+  /**
+   * Returns a list of columns.
+   *
+   * @param dataElement the {@link DataElement}.
+   * @param selectExpression the select expression.
+   * @param dataFilterClause the data filter clause.
+   * @return a list of {@link AnayticsTableColumn}.
+   */
   private List<AnalyticsTableColumn> getColumnFromDataElementWithLegendSet(
-      DataElement dataElement, String select, String dataClause) {
+      DataElement dataElement, String selectExpression, String dataFilterClause) {
     String query =
         """
         (select l.uid from ${maplegend} l
@@ -705,9 +713,9 @@ private List<AnalyticsTableColumn> getColumnFromDataElementWithLegendSet(
                   replaceQualify(
                       query,
                       Map.of(
-                          "select", select,
+                          "select", selectExpression,
                           "legendSetId", String.valueOf(ls.getId()),
-                          "dataClause", dataClause,
+                          "dataClause", dataFilterClause,
                           "column", column));
 
               return AnalyticsTableColumn.builder()