Address review comments

dhis2 · Jan 10, 2025 · a4ff98c · a4ff98c
1 parent 86b6eb1
commit a4ff98c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/...alytics/src/main/java/org/hisp/dhis/analytics/common/ProgramIndicatorSubqueryBuilder.java b/...alytics/src/main/java/org/hisp/dhis/analytics/common/ProgramIndicatorSubqueryBuilder.java
@@ -102,14 +102,14 @@ String getAggregateClauseForProgramIndicator(
       Date earliestStartDate,
       Date latestDate);
 
-  void contributeCTE(
+  void contributeCte(
       ProgramIndicator programIndicator,
       AnalyticsType outerSqlEntity,
       Date earliestStartDate,
       Date latestDate,
       CteContext cteContext);
 
-  void contributeCTE(
+  void contributeCte(
       ProgramIndicator programIndicator,
       RelationshipType relationshipType,
       AnalyticsType outerSqlEntity,

diff --git a/...tics/src/main/java/org/hisp/dhis/analytics/event/data/JdbcEnrollmentAnalyticsManager.java b/...tics/src/main/java/org/hisp/dhis/analytics/event/data/JdbcEnrollmentAnalyticsManager.java
@@ -706,9 +706,9 @@ protected ColumnAndAlias getCoordinateColumn(QueryItem item, String suffix) {
     return ColumnAndAlias.EMPTY;
   }
 
+  @Override
   protected String getColumnWithCte(QueryItem item, String suffix, CteContext cteContext) {
     List<String> columns = new ArrayList<>();
-    String colName = item.getItemName();
 
     CteDefinition cteDef = cteContext.getDefinitionByItemUid(computeKey(item));
     int programStageOffset = computeRowNumberOffset(item.getProgramStageOffset());
@@ -938,15 +938,15 @@ private void handleProgramIndicatorCte(
       QueryItem item, CteContext cteContext, EventQueryParams params) {
     ProgramIndicator pi = (ProgramIndicator) item.getItem();
     if (item.hasRelationshipType()) {
-      programIndicatorSubqueryBuilder.contributeCTE(
+      programIndicatorSubqueryBuilder.contributeCte(
           pi,
           item.getRelationshipType(),
           getAnalyticsType(),
           params.getEarliestStartDate(),
           params.getLatestEndDate(),
           cteContext);
     } else {
-      programIndicatorSubqueryBuilder.contributeCTE(
+      programIndicatorSubqueryBuilder.contributeCte(
           pi,
           getAnalyticsType(),
           params.getEarliestStartDate(),

diff --git a/...sp/dhis/analytics/event/data/programindicator/DefaultProgramIndicatorSubqueryBuilder.java b/...sp/dhis/analytics/event/data/programindicator/DefaultProgramIndicatorSubqueryBuilder.java
@@ -78,18 +78,18 @@ public String getAggregateClauseForProgramIndicator(
   }
 
   @Override
-  public void contributeCTE(
+  public void contributeCte(
       ProgramIndicator programIndicator,
       AnalyticsType outerSqlEntity,
       Date earliestStartDate,
       Date latestDate,
       CteContext cteContext) {
-    contributeCTE(
+    contributeCte(
         programIndicator, null, outerSqlEntity, earliestStartDate, latestDate, cteContext);
   }
 
   @Override
-  public void contributeCTE(
+  public void contributeCte(
       ProgramIndicator programIndicator,
       RelationshipType relationshipType,
       AnalyticsType outerSqlEntity,