Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not apply identifiable token filter to uid length < 4 #19272

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: not apply identifiable token filter to uid length < 4 #19272

merged 1 commit into from
Nov 25, 2024

Conversation

vietnguyen
Copy link
Contributor

@vietnguyen vietnguyen commented Nov 24, 2024 •
edited
Loading

https://dhis2.atlassian.net/browse/DHIS2-17098

Issue

  • identifiable:token:aaa check for name, code and uid.
  • If the token value is too short, it might be contained by a uid which isn't what user wants.

Fix

  • Add a check to skip uid filter if token value is < 4

Test

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vietnguyen vietnguyen changed the title fix: not apply identiable token filter to uid length < 4 fix: not apply identifiable token filter to uid length < 4 Nov 25, 2024
@vietnguyen vietnguyen merged commit fba91c2 into master Nov 25, 2024
15 checks passed
@vietnguyen vietnguyen deleted the DHIS2-17098-42 branch November 25, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbee jbee jbee approved these changes

@netroms netroms netroms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vietnguyen @netroms @jbee