Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify and add unit tests for SqlBuilder [DHIS2-16705] #19282

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

larshelge
Copy link
Member

@larshelge larshelge commented Nov 25, 2024

  • Removes redundant JSON method from SqlBuilder.
  • Improves clarity of parameter names.
  • Adds unit tests.

@larshelge larshelge changed the title test: Add unit test for SqlBuilder [DHIS2-16705] test: Add unit tests for SqlBuilder [DHIS2-16705] Nov 25, 2024
@larshelge larshelge changed the title test: Add unit tests for SqlBuilder [DHIS2-16705] refactor: Simplify and add unit tests for SqlBuilder [DHIS2-16705] Nov 25, 2024
@larshelge larshelge enabled auto-merge (squash) November 25, 2024 12:12
@larshelge larshelge merged commit c0b0f23 into master Nov 25, 2024
15 checks passed
@larshelge larshelge deleted the sqlbuilder-refactor branch November 25, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants