Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move EnrollmentsExportControllerTest to postgres DHIS2-18791 #19685

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Jan 16, 2025

improve our tests of /tracker/enrollments

  • move EnrollmentsExportControllerTest to postgres to ensure we also test the JSONB use correctly
  • use the JSON fixtures via the importer to ensure our setup is in a realistic and valid state
  • make the test @TestInstance(TestInstance.Lifecycle.PER_CLASS) as tests only test the read path so setup can be reused
  • improve assertions by extracting a reusable one

in preparation for https://dhis2.atlassian.net/browse/DHIS2-18791

depends on #19672

@teleivo teleivo changed the title test: DHIS2-18791 test: move EnrollmentsExportControllerTest to postgres DHIS2-18791 Jan 16, 2025
@teleivo teleivo marked this pull request as ready for review January 16, 2025 09:26
@teleivo teleivo enabled auto-merge (squash) January 16, 2025 11:27
@teleivo teleivo merged commit 3a5ec37 into master Jan 16, 2025
17 checks passed
@teleivo teleivo deleted the DHIS2-18791 branch January 16, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants