fix: Update data dimension items as part of cat opt combo merge [DHIS2-18321] #19687
+101
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Luckily, while Jason P was testing some merge scenarios, he stumbled across this error when trying to merge 2 COCs in the SL DB (
KPP63zJPkOu
,TDb5JyDQqho
).Object could not be deleted because it is associated with another object: DataDimensionItem
Cause
After looking into this, it seems that a
DataElementOperand
is also aDataDimensionItem
. Although theDataElementOperand
is updated as part of the merge, this change is not reflected in thedatadimensionitem
table even though it is the sameDataElementOperand
:(The
DataDimensionItem
type does not have aCategoryOptionCombo
property which is how this was missed originally.Fix
The
datadimensionitem
table needs to be updated also as part of the merge.Testing
Automated
E2E test updated so that data dimension items are persisted, which also need updating
Manual
Using this payload failed before the fix, and passes now
POST
/api/categoryOptionCombos/merge