Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Nepali calendar support [DHIS2-18268] #19691

Open
wants to merge 2 commits into
base: 2.41
Choose a base branch
from
Open

fix: Nepali calendar support [DHIS2-18268] #19691

wants to merge 2 commits into from
+154 −34

Conversation

abyot
Copy link
Member

@abyot abyot commented Jan 16, 2025

  • ISO period names should match Nepali calendar. Baisakh 2081 is 208101 not 202404
  • Fix to weekly periods start and end dates

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.9% Duplication on New Code

See analysis details on SonarQube Cloud

@abyot abyot changed the title fix: Nepali calendar support fix: Nepali calendar support [DHIS2-18268] Jan 16, 2025
gnespolino
gnespolino approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@gnespolino gnespolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnespolino gnespolino gnespolino approved these changes

@maikelarabori maikelarabori Awaiting requested review from maikelarabori

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abyot @gnespolino