Skip to content

Commit

Permalink
[ci] Divide subsystem-regression-tests into 2 jobs (paritytech#4076)
Browse files Browse the repository at this point in the history
Currently `subsystem-regression-tests` job fails if the first benchmarks
fail and there is no result for the second benchmark. Also dividing the
job makes the pipeline faster (currently it's a longest job)

cc paritytech/ci_cd#969
cc @AndreiEres

---------

Co-authored-by: Andrei Eres <eresav@me.com>
  • Loading branch information
alvicsam and AndreiEres authored Apr 11, 2024
1 parent f13408d commit 6ebf491
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 4 deletions.
8 changes: 6 additions & 2 deletions .gitlab/pipeline/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ publish-subsystem-benchmarks:
- .kubernetes-env
- .publish-gh-pages-refs
needs:
- job: subsystem-regression-tests
- job: subsystem-benchmark-availability-recovery
artifacts: true
- job: subsystem-benchmark-availability-distribution
artifacts: true
- job: publish-rustdoc
artifacts: false
Expand Down Expand Up @@ -109,7 +111,9 @@ trigger_workflow:
needs:
- job: publish-subsystem-benchmarks
artifacts: false
- job: subsystem-regression-tests
- job: subsystem-benchmark-availability-recovery
artifacts: true
- job: subsystem-benchmark-availability-distribution
artifacts: true
script:
- echo "Triggering workflow"
Expand Down
21 changes: 19 additions & 2 deletions .gitlab/pipeline/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -511,12 +511,12 @@ test-syscalls:
fi
allow_failure: false # this rarely triggers in practice

subsystem-regression-tests:
subsystem-benchmark-availability-recovery:
stage: test
artifacts:
name: "${CI_JOB_NAME}_${CI_COMMIT_REF_NAME}"
when: always
expire_in: 1 days
expire_in: 1 hour
paths:
- charts/
extends:
Expand All @@ -525,6 +525,23 @@ subsystem-regression-tests:
- .run-immediately
script:
- cargo bench --profile=testnet -p polkadot-availability-recovery --bench availability-recovery-regression-bench --features subsystem-benchmarks
tags:
- benchmark
allow_failure: true

subsystem-benchmark-availability-distribution:
stage: test
artifacts:
name: "${CI_JOB_NAME}_${CI_COMMIT_REF_NAME}"
when: always
expire_in: 1 hour
paths:
- charts/
extends:
- .docker-env
- .common-refs
- .run-immediately
script:
- cargo bench --profile=testnet -p polkadot-availability-distribution --bench availability-distribution-regression-bench --features subsystem-benchmarks
tags:
- benchmark
Expand Down

0 comments on commit 6ebf491

Please sign in to comment.