Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
Diego Jesus committed Aug 24, 2024
1 parent 3e8d4cf commit 753fe08
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
}
steps:
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: 'pagoda'

Expand All @@ -53,7 +53,7 @@ jobs:
-E tar cJfv "${{ matrix.config.name }}.tar.xz" "${{ github.workspace }}/build/pagoda")
- name: Upload
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v3
with:
path: ./${{ matrix.config.name }}.tar.xz
name: ${{ matrix.config.name }}.tar.xz
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ cmake_policy(SET CMP0091 NEW)

set(version 0.1.0)

cmake_minimum_required(VERSION 3.30.0 FATAL_ERROR)
project("Pagoda" LANGUAGES CXX VERSION ${version})
cmake_minimum_required(VERSION 3.11.0 FATAL_ERROR)

list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
list(APPEND CMAKE_MODULE_PATH "${CMAKE_BINARY_DIR}")
Expand Down
8 changes: 4 additions & 4 deletions cmake/Pagoda.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ function (add_pagoda_build_unit)
# Shared libraries
$<$<BOOL:${PAGODA_SHARED_LIB}>:PAGODA_SHARED_LIB>
${PARSED_ARGS_COMPILE_DEFINITIONS}
# Prevent Boost from using deprecated functions on mac
$<$<PLATFORM_ID:Darwin>:BOOST_NO_CXX98_FUNCTION_BASE>
# Prevent boost from using deprecated functions on Mac
$<$<PLATFORM_ID:Darwin>:
)

set_target_properties(${PARSED_ARGS_NAME}
Expand Down Expand Up @@ -198,6 +198,8 @@ function (add_pagoda_header_only)
"${singleValue}" # list of names of mono-valued arguments
"${multiValue}" # list of names of multi-valued arguments (output variables are lists)
${ARGN} # arguments of the function to parse, here we take the all original ones
)
${ARGN} # arguments of the function to parse, here we take the all original ones
)
# note: remaining unparsed arguments can be found in variable PARSED_ARGS_UNPARSED_ARGUMENTS
if(NOT PARSED_ARGS_NAME)
Expand Down Expand Up @@ -405,8 +407,6 @@ function (add_unit_test unit_test_src)
set(unit_test_libs GTest::gtest GTest::gtest_main)

add_pagoda_executable(
NAME ${test_name}
SOURCES ${unit_test_src}
DEPENDENCIES ${unit_test_libs}
)

Expand Down

0 comments on commit 753fe08

Please sign in to comment.