Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js version to latest LTS #446

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

NiccoMlt
Copy link
Contributor

Upgrade Node.js from Gallium LTS to Iron LTS.

The currently-used version is a problem with Mac on Apple M2 processors while building node-gyp.

Also, according to roadmap it is in end of life: https://github.com/nodejs/Release.

@hamadodene
Copy link
Contributor

@NiccoMlt Ok to me..
Can you fix tests?

@pv3nturi PTAL

@NiccoMlt
Copy link
Contributor Author

NiccoMlt commented Nov 2, 2023

Can you fix tests?

Yes, I should, but test result collection is broken, I should fix it first...

 * upgrade Node.js from Gallium LTS to Iron LTS
 * upgrade yarn lockfile
@NiccoMlt NiccoMlt self-assigned this Feb 21, 2024
@hamadodene hamadodene merged commit fe1cfdf into diennea:master Feb 22, 2024
2 checks passed
@NiccoMlt NiccoMlt deleted the upgrade-node branch February 22, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants