Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2 - Enable http2 H2C #483

Merged
merged 11 commits into from
Aug 7, 2024
Merged

HTTP/2 - Enable http2 H2C #483

merged 11 commits into from
Aug 7, 2024

Conversation

NiccoMlt
Copy link
Contributor

@NiccoMlt NiccoMlt commented Jul 16, 2024 •
edited
Loading

Replaces outdated #449, closes #409

  • replaced mixed versions of hamcrest-core with latest version on hamcrest
  • many minor refactors and code cleanups, including adding more documentation to the code
  • moved UriCleaner to observer from connection, as HTTP/2 uses a different pipeline structure
  • added protocol configuration to listener configuration
  • cleaned up build scripts
  • added gitignore for build-related artifacts of Docker image

To use the new configuration, you have to your listeners configurations a protocol property, which may assume one or more of the following values (separated by commas):

The strings should be case-insensitive.

Default value is HTTP11,H2C if ssl is not enabled, or HTTP11 is ssl is enabled.

NiccoMlt added 2 commits July 16, 2024 10:41
@NiccoMlt
Squashed commit of the following:
bdf85cc 
commit 7f26aa6
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Wed May 24 11:33:01 2023 +0200

    test: repair tests

commit 133c9b8
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Wed May 24 11:32:12 2023 +0200

    feat: adding HTTP/2.0 protocol support to server configuration

commit 92778b0
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Tue May 23 09:10:51 2023 +0200

    feat: adding HTTP/2.0 protocol support to server

commit 3b664e3
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Tue May 23 09:08:18 2023 +0200

    test: ignore JUnit Jupiter transitive dep

    see #440
@NiccoMlt
Squashed commit of the following:
fc30bd7 
commit e406f5c
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Wed Nov 8 10:57:47 2023 +0100

    feat: HTTP/2 seems to work

commit b862985
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Tue Nov 7 15:38:44 2023 +0100

    chore: stash commit

commit 55e4a61
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Thu Nov 2 13:45:45 2023 +0100

    Revert "test: trying to enforce H11, H2, and H2c with secure on forward"

    This reverts commit 9e9e422.

commit 9e9e422
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Thu Nov 2 13:45:34 2023 +0100

    test: trying to enforce H11, H2, and H2c with secure on forward

commit e4db43e
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Thu Nov 2 12:33:55 2023 +0100

    test: workaround on test fixing

commit 3cbee46
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Thu Nov 2 11:44:18 2023 +0100

    feat: allow multiple protocols for listeners

commit 1dfe04b
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Thu Nov 2 10:35:54 2023 +0100

    feat: use a single protocol per connection pool

commit a4aca75
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Tue Oct 31 12:51:05 2023 +0100

    docs: spread some documentation while recovering what to do

commit bed4a42
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Mon Oct 30 18:44:26 2023 +0100

    build: minor adjustment to Git tracking configs and scripts

commit c0a98b9
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Wed May 24 11:33:01 2023 +0200

    test: repair tests

commit 368baee
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Wed May 24 11:32:12 2023 +0200

    feat: adding HTTP/2.0 protocol support to server configuration

commit 3449650
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Tue May 23 09:10:51 2023 +0200

    feat: adding HTTP/2.0 protocol support to server

commit c735c92
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Tue May 23 09:08:18 2023 +0200

    test: ignore JUnit Jupiter transitive dep

    see #440

commit 38f4fa0
Author: Niccolò Maltoni <niccolo.maltoni@diennea.com>
Date:   Mon Oct 30 18:05:50 2023 +0100

    build: upgrade Node.js version to latest LTS

     * upgrade Node.js from Gallium LTS to Iron LTS
     * upgrade yarn lockfile
@NiccoMlt NiccoMlt linked an issue Jul 16, 2024 that may be closed by this pull request
HTTP/2 - Enable http2 H2C #409
Closed
@NiccoMlt NiccoMlt mentioned this pull request Jul 16, 2024
Closed
5 tasks
@NiccoMlt NiccoMlt marked this pull request as draft July 16, 2024 14:33
@NiccoMlt NiccoMlt self-assigned this Jul 23, 2024
@NiccoMlt NiccoMlt force-pushed the 409-http2-enable-http2-h2c branch from 7309b52 to 5feb2e2 Compare July 25, 2024 01:25
@NiccoMlt NiccoMlt marked this pull request as ready for review July 25, 2024 02:36
@NiccoMlt NiccoMlt requested a review from hamadodene July 25, 2024 02:36
@hamadodene
Copy link
Contributor

I followed the development process with @NiccoMlt . From my side, it's okay... but I also ask for a review from @diegosalvi @pv3nturi @diegosalvi

@hamadodene hamadodene requested a review from dmercuriali July 29, 2024 15:16
@dmercuriali dmercuriali merged commit 9644ada into master Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamadodene hamadodene hamadodene approved these changes

@diegosalvi diegosalvi Awaiting requested review from diegosalvi

@pv3ntur1 pv3ntur1 Awaiting requested review from pv3ntur1

@dmercuriali dmercuriali Awaiting requested review from dmercuriali

Assignees

@NiccoMlt NiccoMlt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP/2 - Enable http2 H2C
3 participants
@NiccoMlt @hamadodene @dmercuriali