Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificates > admin ui certificates warning #486

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

NiccoMlt
Copy link
Contributor

@NiccoMlt NiccoMlt commented Aug 28, 2024

Main contribution

Added some buttons on the top to filter the list according to most interesting states:

  • available
  • domain unreachable
  • expired

image

Also, added a warning with the count of unreachable certificates.

image

Additional contributions

  • clean-up documentation and some deprecation warnings in the impacted area or reported by ESLint
  • upgrade development depdencencies according to latest Vue 2 project scaffold (legacy setup)
  • move ESLint config out of package.json for better IDE support

@NiccoMlt NiccoMlt linked an issue Aug 28, 2024 that may be closed by this pull request
@NiccoMlt NiccoMlt force-pushed the 402-certificates-admin-ui-certificates-warning branch from f74dfd8 to 924c4fb Compare August 29, 2024 07:31
@NiccoMlt NiccoMlt self-assigned this Aug 29, 2024
Copy link
Contributor

@dmercuriali dmercuriali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmercuriali dmercuriali merged commit d720d24 into master Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificates > admin ui certificates warning
2 participants