Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge dependency versions #500

Merged
merged 23 commits into from
Oct 21, 2024
Merged

Conversation

NiccoMlt
Copy link
Contributor

@NiccoMlt NiccoMlt commented Oct 15, 2024

Closes #476

@NiccoMlt NiccoMlt linked an issue Oct 15, 2024 that may be closed by this pull request
fixes duplicates:
* jakarta.xml.bind:jakarta.xml.bind-api:3.0.1
* com.fasterxml.jackson.core:jackson-databind:2.14.1
* com.fasterxml.jackson.core:jackson-annotations:2.14.1
* com.fasterxml.jackson.core:jackson-core:2.14.1
@NiccoMlt NiccoMlt force-pushed the 476-non-converging-dependencies branch from 5ad64aa to 27bff23 Compare October 18, 2024 10:44
removes dependencies to:
* org.checkerframework:checker-qual
* com.google.errorprone:error_prone_annotations
* com.google.code.findbugs:jsr305
we had to upgrade ZooKeeper to 3.7.1+ to drop log4j dependency
* org.apache.zookeeper:zookeeper
* commons-io:commons-io
* org.apache.zookeeper:zookeeper-jute
@NiccoMlt NiccoMlt self-assigned this Oct 18, 2024
@NiccoMlt NiccoMlt force-pushed the 476-non-converging-dependencies branch 2 times, most recently from 936f734 to b2c024d Compare October 18, 2024 22:11
@NiccoMlt NiccoMlt force-pushed the 476-non-converging-dependencies branch from 22a3ced to 110180e Compare October 19, 2024 13:49
@NiccoMlt NiccoMlt marked this pull request as ready for review October 20, 2024 17:01
@NiccoMlt NiccoMlt added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 21, 2024
@NiccoMlt
Copy link
Contributor Author

Note for the reviewer: please don't squash merge, I want to retain each individual commit, as they were split with caution and individually tested!

Please use rebase and merge

@NiccoMlt NiccoMlt requested a review from hamadodene October 21, 2024 09:40
@dmercuriali dmercuriali merged commit 04f6cc9 into master Oct 21, 2024
2 checks passed
@NiccoMlt NiccoMlt deleted the 476-non-converging-dependencies branch October 21, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-converging dependencies
3 participants