-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: migrate logger to SLF4J APIs + Logback backend #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NiccoMlt ... Look good to me...
Please add also a note in the README or in another place for migration from logger to SL4J when user will install this PR.
I don't think that documenting it in the README would be useful, as the logger is an implementation detail that we already are not talking about. I think we should document it in the changelog when we release it. What do you think? |
Make sense...thanks |
carapace-server/src/main/java/org/carapaceproxy/utils/CarapaceLogger.java
Outdated
Show resolved
Hide resolved
@NiccoMlt +1 but a rebase is needed |
@dmercuriali thanks, I'll do it later this afternoon |
* drop Apache Commons Logging dependency * add Apache Commons Logging to SLF4J adapter because of other dependencies * drop JUL backend for SLF4J * add Logback as backend for SLF4J
� Conflicts: � carapace-server/src/main/java/org/carapaceproxy/core/Listeners.java � carapace-server/src/main/java/org/carapaceproxy/core/ProxyRequestsManager.java
7bc06c2
to
2e19e4a
Compare
@dmercuriali gave a +1 to the PR yesterday, @hamadodene approved the PR today after the rebase, and the CI passed, so I'm merging it to unlock #516 and hopefully #512 |
java.util.logging
usages to SLF4JThe logger doesn't need the
logging.properties
file anymore.The configuration
logging.debug.enabled
was dropped; just configure the log level in thelogback.xml
file instead