Restructure the interrupt logic #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a rcvar,
gh_actions_sleep, to allow the user greater control over the timing of the interruptions throughout the loop to mitigate the risk of racing process termination against the workflow.Both
service gh_actions stopandservice gh_actions forcestoprequire that the pkill signal be sent to the pot; killing eachgithub-runners.${RUNNER_NAME}process is insufficient alone.The PR also eliminates one of the conditions checking
/var/run/github-runners.${RUNNER_NAME}and moves the graceful termination accordingly.