Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM to the upstream jail #25

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Add LLVM to the upstream jail #25

merged 1 commit into from
Jul 26, 2024

Conversation

elisehaldane
Copy link
Collaborator

Pull Request

Checklist

  • Have you read Digital Catapult's Code of Conduct?
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

PR Type

Please delete options that are irrelevant.

  • Feature

High level description

This change adds the LLVM package to the upstream jail, to reduce the time taken for a workflow to finish.

Describe alternatives you've considered

GitHub caching might be an option, but adding packages directly to a jail is more in keeping with the design of Pot itself and its objective of offering containerisation within FreeBSD. A cache couldn't be exported along with the jail, when running pot export, hence the build artefact wouldn't be an accurate recreation of the original state. As a result, installing packages with a view to exporting the jail as a tarball is still the preferred approach.

@elisehaldane elisehaldane merged commit b2cb6a4 into main Jul 26, 2024
2 checks passed
@elisehaldane elisehaldane deleted the feature/llvm_base branch July 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants