feat!: replace createdBy with originalVersionId
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See <digidem/comapeo-core#371> for details.
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Jul 10, 2024
This patch: - Removes `createdBy` from documents. Removes `MapeoProject.prototype.$createdByToDeviceId` as a side-effect. - Returns `originalVersionId` on all documents. Closes <#371>. Depends on <https://github.com/digidem/mapeo-schema/pull/191> and <digidem/mapeo-mock-data#7>.
EvanHahn
commented
Jul 10, 2024
package.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@faker-js/faker": "^8.3.1", | |||
| "@mapeo/schema": "^3.0.0-next.16", | |||
| "@mapeo/schema": "file:mapeo-schema-3.0.0-next.16.tgz", | |||
There was a problem hiding this comment.
See https://github.com/digidem/mapeo-schema/pull/191. I'll deploy a new version of the dependency before merging this PR.
gmaclennan
approved these changes
Jul 11, 2024
This was referenced Aug 24, 2024
EvanHahn
added a commit
to digidem/comapeo-core
that referenced
this pull request
Aug 27, 2024
This patch: - Removes `createdBy` from documents. Removes `MapeoProject.prototype.$createdByToDeviceId` as a side-effect. - Returns `originalVersionId` on all documents. - Updates `@mapeo/schema` to the latest version, which requires a bunch of other changes. Closes [#371](#371). See <https://github.com/digidem/mapeo-schema/pull/191> and <digidem/mapeo-mock-data#7>. Co-Authored-By: Tomás Ciccola <tciccola@digital-democracy.com>
This was referenced Aug 29, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See digidem/comapeo-core#371 for details.