Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds make choice test story #245

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bulbil
Copy link
Contributor

@bulbil bulbil commented Mar 25, 2024

@stephenwf @abrin here is an example test of an issue we've been working through: How to handle choice in sequence panel?

Expected

Supplying a valid choice id as a makeChoice() argument will update any annotation page choice currently displayed, even when displaying a sequence with multiple canvases and multiple annotation pages.

Observed

  • Valid choice ids do not update annotation instances in some cases
  • With multiple annotation pages, (I believe) only annotation pages on one of the canvases is available to apply choice at a time

I believe the issue is that it is not obvious in sequence panel which is the current viewer reference (or whether that is even exposed) when makeChoice is called.

In the supplied story:

  • Canvas 3: should toggle between two choices (verso, recto) but does not
  • Canvas 11: "Toggle current choice" sometimes toggles the annotation page on the left and sometimes on the right.
  • Canvas 11: Valid choice ids sometimes (see dropdown select) will affect one but not both annotation pages.
Screenshot 2024-03-25 at 12 58 12 PM

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for canvas-panel-storybook ready!

Name Link
🔨 Latest commit 675692a
🔍 Latest deploy log https://app.netlify.com/sites/canvas-panel-storybook/deploys/6601d50ec0f2f700085ad546
😎 Deploy Preview https://deploy-preview-245--canvas-panel-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for iiif-canvas-panel-demos ready!

Name Link
🔨 Latest commit 675692a
🔍 Latest deploy log https://app.netlify.com/sites/iiif-canvas-panel-demos/deploys/6601d50e5173010008314862
😎 Deploy Preview https://deploy-preview-245--iiif-canvas-panel-demos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for iiif-canvas-panel ready!

Name Link
🔨 Latest commit 675692a
🔍 Latest deploy log https://app.netlify.com/sites/iiif-canvas-panel/deploys/6601d50eaa94040008013af4
😎 Deploy Preview https://deploy-preview-245--iiif-canvas-panel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 675692a:

Sandbox Source
simple-vue Configuration
vue-3-carousel Configuration
external-stylesheet-sandbox Configuration
example-sandbox Configuration
custom-preset Configuration
react-choices-example Configuration
reacting-to-the-user Configuration
external-annotation-pages Configuration
virtual-annotation-pages Configuration
loading-annotation-pages Configuration
annotation-display-1 Configuration
annotation-display-2 Configuration
choice-example Configuration
choice-react Configuration
more-regions-1 Configuration
more-regions-2 Configuration
regions-1 Configuration
regions-2 Configuration
regions-3 Configuration
regions-4 Configuration
regions-5 Configuration
regions-6 Configuration
responsive-1 Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant