-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds make choice test story #245
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for canvas-panel-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for iiif-canvas-panel-demos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for iiif-canvas-panel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 675692a:
|
@stephenwf @abrin here is an example test of an issue we've been working through: How to handle choice in sequence panel?
Expected
Supplying a valid choice id as a
makeChoice()
argument will update any annotation page choice currently displayed, even when displaying a sequence with multiple canvases and multiple annotation pages.Observed
I believe the issue is that it is not obvious in sequence panel which is the
current
viewer reference (or whether that is even exposed) whenmakeChoice
is called.In the supplied story: