-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atlas version v2.0.9 #250
Atlas version v2.0.9 #250
Conversation
✅ Deploy Preview for canvas-panel-storybook canceled.
|
✅ Deploy Preview for iiif-canvas-panel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for iiif-canvas-panel-demos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0ec5bac:
|
@abrin Using the choice example (which forces a single layer) I think I can see the issue resolved. Before: After: (After some issues getting the version pinned!) |
There is one final bug, when setting opacity our new calculations have the opposite problem. They will (sometimes) overlap at zoom levels and create opaque lines. OpenSeadragon fixes this by clearing the contents beneath before rendering, but that will not work for Atlas since you can compose images together, like this example. One option might be to clear/reset the pixels on the right and bottom. This would reduce the bug to showing lines on the image behind only - which is probably going to be less noticeable for users and rarer to see. There might be a performance overhead with that approach though, so it would only be if there is an opacity set. If you're happy with the current implementation though, we can look at that bug later. (link to bug: https://deploy-preview-250--iiif-canvas-panel.netlify.app/docs/examples/styling#opacity) |
@abrin This is the changes that were applied to Atlas, resolves #248