add story for non-interactive canvas #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is dependent on atlas-viewer/atlas#55, and aims to demonstrate that setting interactive=false in CanvasPanel disables the mousewheel and touch interactions
❌ Deploy Preview for iiif-canvas-panel failed.
|
❌ Deploy Preview for canvas-panel-storybook failed.
|
✅ Deploy Preview for iiif-canvas-panel-demos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4237fa3:
|
abrin
commented
Aug 15, 2024
packages/canvas-panel/yarn.lock
Outdated
Comment on lines
29
to
31
| "@atlas-viewer/atlas@https://pkg.csb.dev/atlas-viewer/atlas/commit/567c644a/@atlas-viewer/atlas": | ||
| version "2.2.6" | ||
| resolved "https://pkg.csb.dev/atlas-viewer/atlas/commit/567c644a/@atlas-viewer/atlas#767a57610e3e32ca8b1721644b56645732c7c034" |
There was a problem hiding this comment.
@stephenwf hmm... should this be 2.2.8?
There was a problem hiding this comment.
Yes :/ yarn is a bit of a pain sometimes. It might work if you add it to the resolutions field.
I think for this repository I also need to publish a 2.0.15 that doesn't have the changes from #237
There was a problem hiding this comment.
I think that worked, though it did update one of the helpers at the same time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on atlas-viewer/atlas#55, and aims to demonstrate that setting interactive=false in CanvasPanel disables the mousewheel and touch interactions