Auth2 updates + deserialisation #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Interactive" -> "Active" profile main change. Changing some values based on required/optional status
JackLewis-digirati
approved these changes
Jul 17, 2023
griffri
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Made the following changes to Auth2 models based on finalised spec:
AuthAccessService2has"active"profile, rather than"interactive".AuthProbeResult2:Statusis now requiredSubstituteis a list andIServicerather thanJsonLdBase.LocationisIServicerather thanJsonLdBaseAuthAccessTokenError2constructor takes optionalLanguageMapas note is optional.AccessTokenandMessageIdare required forAuthAccessToken2Added deserialisation tests - these are basic tests verifying that we can deserialise the output of existing serialisation tests.