Make iiif-net parse all the Manifests in the Cookbook #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IIIF Cookbook:
https://theseus-viewer.netlify.app/cookbook-collection.json
https://iiif.io/api/cookbook/
Audio
toSound
(the latter is correct in the spec). I considered just using the string but it breaks the pattern of usingnameof
to when comparing type values.ISource
andISourceConverter
forSpecificResource
When I ran the full test suite there were loads of breaking tests - but they all seem to be string comparisons of expected and actual JSON, when the JSON is actually equivalent.
In the PMC work I used this quite a bit:
https://github.com/lateapexearlyspeed/Lateapexearlyspeed.JsonSchema?tab=readme-ov-file#lateapexearlyspeedxunitassertionjson
(see JsonAssertion.Equivalent)
Should we use something like that?