Tl/crash #91
Closed
Tl/crash #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2023 14:19
…Also cleaned up some unused logs
… checking from hard coded values to using the issuer-registy-client
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr addresses issues #52 and #45.
issue #52 is addressed by switching from the hard coded registry values to the issuer-registry-client library.
issue #45 is addressed by adding a check to see if a proof field is in the credential. This fix is implemented in a way that makes it easy to send a different message for each missing piece of a credential in the future.
Note: A big part of these fixes is sending a error back to the display page. This is done with a mostly static error object that contains some hard coded data that in theory should be changed.